bugfix: data race in pkg cri/stream #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
==========================================
+ Coverage 63.74% 63.75% +0.01%
==========================================
Files 200 200
Lines 15527 15527
==========================================
+ Hits 9898 9900 +2
+ Misses 4396 4394 -2
Partials 1233 1233
|
fuweid
reviewed
Jul 30, 2018
cri/stream/portforward/httpstream.go
Outdated
| p.printError(msg) | ||
| case <-p.complete: | ||
| logrus.Infof("(conn=%v, request=%s) successfully received error and data streams", h.conn, p.requestID) | ||
| logrus.Infof("(conn=%p, request=%s) successfully received error and data streams", h.conn, p.requestID) |
There was a problem hiding this comment.
could we update it with address of connection? I don't think the %p can provide useful information here.
fuweid
reviewed
Aug 1, 2018
cri/stream/portforward/httpstream.go
Outdated
|
|
||
| if err != nil { | ||
| msg := fmt.Sprintf("error forwarding port %d to pod %s: %v", port, h.pod, err) | ||
| msg := fmt.Sprintf("PortForward of CRI: error forwarding port %d to pod %s: %v", port, h.pod, err) |
There was a problem hiding this comment.
prefer to use lowercase in the message.
YaoZengzeng
force-pushed
the
stream-race
branch
from
7882693 to
5a522fa
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
stream-race
branch
from
5a522fa to
1e1f3f2
Compare
|
@fuweid Updated. |
This was referenced Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
There is an data race in pkg
cri/streamwhen I build pouchd with flag-raceand use cri-tools to test the stream server related api:%vwill read the underlying structure which is the source of the data racewe should use the
%pto avoid it.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews